-
Notifications
You must be signed in to change notification settings - Fork 20
[김현지] 리팩토링 약간과 버그 찾기 데이 #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimhji
wants to merge
37
commits into
softeerbootcamp-7th:kimhji
Choose a base branch
from
kimhji:refactor_overall1
base: kimhji
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat extra1
- router의 route input을 prefix 방식으로 탐색하도록 변경 - static 파일과 사용자가 등록해서 따로 저장해둔 이미지를 처리하는 방식을 분리하기 위해 api 추가
|
main 브랜치로 병합 시도 || 적절한 라벨이 있는지 확인해 주세요. |
1 similar comment
|
main 브랜치로 병합 시도 || 적절한 라벨이 있는지 확인해 주세요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
완료 작업 목록
고민
테스트를 하면서, 임계값 테스트를 잘 진행했다고 생각했는데.. 아니었습니다.
다른 분들과 같이 테스트 해보면서 어떤 부분을 더 신경써야할 지를 배울 수 있었던 것 같습니다.